↓ Twitter is updated more often, so read it! ↓
«
»

Autonomous LAN Party is a mess

2007 December 9 0116

<venting>

I’m looking through the ALP source while Jon and Zack work on adding PayPal integration.

This code is not easily readable. I know the developers probably didn’t aim for MVC, but if they did, they failed. The page class is called universal. What does that do? What does it mean? UniversalPage would be a better class name, or better yet, Page or GenericPage or PageGeneric.

Then, in /include/modules/mod_controlpanel.php, there’s a Javascript function that, if I’m understanding it correctly, catches the user’s login and md5()s the password, then sends that in the request instead of the plain text password. It then stores/checks that md5 in the database. THERE IS NO POINT TO THIS. Elementary security procedures show this. Needless to say, we’re going to have to fix this.
</venting>

Category: programs  |  Tags: Tags: , , ,  |  Comment (RSS)  |  Trackback

4 Comments

  1. Sean:

    Yeah… when I was integrating ALP with Pittco’s website last year, I saw that issue as well and was like “WTF?!”

    12 December 2007, 12:14 am

  2. Zach Leatherman:

    Hey Colin,
    I am the original developer that started the ALP project. I’ll be the first to admit that Object Oriented Programming wasn’t at the top on the list of priorities at the time, we didn’t have the great variety of well documented PHP frameworks that we have today. But, it was a project I enjoyed working on for our local LAN party that we ran in Nebraska. The truth is, looking back at any code you wrote on a project 5 years ago is going to be painful, because programming is an iterative learning process. But, we put it out there in the hope that some people would get some use out of it, and a lot of people have.

    Good luck with your fixing, and why not contribute your patches back to the project?

    Thanks,
    Zach

    8 October 2008, 11:40 pm

  3. Nick Brooks:

    Did you get the PayPal integration to work, and if so, would you be willing to share it?

    12 October 2008, 2:20 pm

  4. Colin Dean:

    Thanks for your comments, Zach and Nick.

    I have to admit that five years ago, I didn’t even know what object-oriented programming is! Things have come a long way for sure.

    I’ll talk to the guy who did the work and check if he’s OK with contributing it.

    12 October 2008, 6:54 pm

Leave a comment